jhipster/jhipster-core

JDL should add 'generator-jhipster' prefix to blueprints.

mshima opened this issue · 11 comments

mshima commented
Overview of the issue

Blueprints jdl options should allow blueprints [vuejs] value.
To keep consistency with cli jhipster --blueprints vuejs.

And all blueprints should be merged unique by name.

Motivation for or Use Case
Reproduce the error

blueprints [vuejs] creates

blueprints: {
  name: 'vuejs'
}

at .yo-rc.json.

Should be

blueprints: {
  name: 'generator-jhipster-vuejs'
}
Related issues
Suggest a Fix
JHipster Version(s)
JHipster configuration
Entity configuration(s) entityName.json files generated in the .jhipster directory
Browsers and Operating System
  • Checking this box is mandatory (this is just to show you read everything)
MathieuAA commented

Two comments later: I've finally re-read the issue (sorry, I shouldn't ever read issues in the morning). Okay

  • 👍1
mshima commented

Thanks @MathieuAA.
About merging with .yo-rc.json existing values unique by name?
It's too difficult?

Currently it's overriding .yo-rc.json values.

MathieuAA commented

Quite easy I guess. Can't do it today though

mshima commented

@MathieuAA no problem.

MathieuAA commented

@mshima didn't think about it yesterday: why would we merge?

mshima commented

@MathieuAA do you think we should force to set update the jdl too?

jhipster import-jdl foo-with-kotlin --blueprints vuejs
jhipster import-jdl foo-updated-with-kotlin

The second jhipster import-jdl will remove the vuejs blueprint and create angular files with the existing vuejs files.
Seems right to me to don't require the user to add vuejs to jdl or adding the cli option when regenerating.

MathieuAA commented

It's simple. We should remove the --blueprints option. Anything that can be overridden by JDL "code" shouldn't be an option.

MathieuAA commented

Again, I don't get why we should merge... There should be precedence rules.

mshima commented

I am thinking about jhipster/generator-jhipster#11770.
So jhipster jdl https://github.com/jhipster/jdl-samples/blob/master/library.jh --blueprints vuejs should export the jdl once the import is done.

MathieuAA commented

Again, I don't think it's a good idea to provide blueprints from the CLI instead of providing them from the JDL file.

mshima commented

This is related to kickstarting a sample application with user customised options.
https://groups.google.com/d/msg/jhipster-dev/UaV6pQwmYFQ/XGgnkS3aCAAJ

Just forget about this.