jiri-otoupal/pycrosskit

desktop and start_menu params get switched

Closed this issue · 0 comments

Describe the bug
The start_menu and desktop parameters get switched in different functions depending on your platform
i.e specifying start_menu=True in create_shortcut would cause a desktop shortcut to be made and not a start_menu shortcut

Additional context
Within the code, the order of the parameters in the function definition is different from that in which they are passed to said function
this is true for create_shortcut() on linux
and for delete_shortcut() on desktop

Moreover since this affects the path returned to testing code, this was not caught in the tests