jirojo2/blockchain-developer-bootcamp-final-project

Some things to consider

thedarkjester opened this issue · 1 comments

I am currently marking your project and can give the following feedback:

  1. The avoiding attacks pull over push isn't quite accurate as you transfer on close of the game. This should be a withdraw-able balance for the winner to with withdraw vs. transfer. Additionally, the recommended way to transfer is to use .call vs. .transfer
  2. The specific version of the pragma should be without the ^ as this means anything in 0.8.x can be used and if a flaw existed in an earlier/later version it would break.
  3. You could also note you are using a factory pattern by creating them from within the Casino contract that behaves as a factory
  4. Consider a different data structure that may have a smaller array size - that could get pretty big if there are many games played
  5. Changing addresses breaks the UI - I swapped and it just turned into a white screen
  6. Swapping networks doesn't refresh the UI at all - also consider adding a "you are on this network" message
  7. Overall the UI works pretty well - a nice to have would be to show your address as You in the games list if you registered it
  8. When running the tests against ganache the first test fails

Thanks for the feedback!