jivesoftware/jive-sdk

Replace relative image links with fully qualified paths in the docs

Opened this issue · 3 comments

markweitzel commented

If you look at the NPM, all of the image links are broken. This is because NPM picks up the readme.md from github. However, because there are relative URLs in the docs, it tries to resolve everything at npm.org. Es no bueno.
https://npmjs.org/package/jive-sdk

5minpause commented

Is this still relevant? Could you point me to where at NPM things are breaking? If I visit https://www.npmjs.org/package/jive-sdk in the browser I cannot see any images as there are no images referenced inside of readme.md. What did I miss here?

5minpause commented

I saw this #11. This issue seems to be a duplicate? I guess you could close it then. @markweitzel, @rachoac @ryanrutan

matthewmccullough commented

This appears to have been fixed in two waves.

  1. The images were made absolute in 8e63a12
  2. The images were removed from the README.md in 6d8f998

Looks like we're good to go. Let's close this issue, @markweitzel and @ryanrutan.