Typo in the README.md: `assert called` and not `assert_called`

Question

Typo in the README.md: `assert called` and not `assert_called`

Closed this issue 7 years ago · 4 comments

It seems there is a typo in the readme. Basically in the examples you wrote assert_called, but the correct one should be assert called. Is it right?

Thank you 🚀

Answer 1 · 2018-07-16T22:29:57.000Z

Nope, it was a recent change made by @mtrudel. Please see #87

Answer 2 · 2018-07-17T07:34:45.000Z

Oh cool! Thank you 👍

Answer 3 · 2018-07-26T16:03:28.000Z

I just ran into the same issue. While that may be the case @Olshansk, the problem is it is a recent unreleased change. Personally I think it is incorrect to have your master branch documentation be referring to an as yet unreleased version of the library, at least with no note.

Perhaps a header warning of the breaking changes, with a link to the currently released Hex docs would be appreciated for the next person that hits this issue?

Answer 4 · 2018-08-04T20:18:29.000Z

@bessey I published v0.3.2.

For some reason the default docs page still points to v0.3.1, but the docs for v0.3.2 are available. I'm not sure if it takes time to propagate of if it's a configuration issue. I'll check back on it in a bit.