jjranalli/nightwind

Better toggling

quick007 opened this issue · 5 comments

quick007 commented

I made an issue a few days ago asking some questions, and I really think something like this would help with bigger, account-based applications:

nightwind.toggle(true)
//toggles nightwind on

nightwind.toggle(false)
//toggles nightwind off
Djiit commented

I think toggle is intended to be switching on and off, depending on the current state. Maybe we could add setDarkMode/setLightMode ? Added a PR with a proposed interface.

  • 👍2
Djiit commented

@quick007 is it better now that we merged the PR ?

jjranalli commented

@Djiit The PR was merged into a separate branch. It will get merged with the main branch on the next major v1.2.0 release! Hopefully soon :)

  • 👍1
quick007 commented

I'm going to go ahead and close this because of #21

jjranalli commented

Closing as the issue has been fixed in 1.1.12