jk1/Gradle-License-Report

Custom JSON file for LicenseBundleNormalizer is not honored

Opened this issue · 3 comments

amotl commented

Dear Evgeny and Günther,

while trying to come up with a patch for #218, I discovered an issue that when configuring the LicenseBundleNormalizer to use a JSON file with custom rules, it is apparently not honored.

new LicenseBundleNormalizer(bundlePath: "${project.rootDir}/gradle/license-normalizer-bundle.json")

While the process croaks with No such file or directory when referencing an unknown file, it succeeds when specifying an existing file. However, the file content is not honored at all - I verified this by corrupting its content, essentially making it an invalid JSON file.

With kind regards,
Andreas.

P.S.: Maybe #182 has the same root cause.
P.P.S.: As this feature apparently was contributed by @guenhter the other day, I am hereby tagging him here.

darxriggs commented

The provided file is honored but the default configuration file default-license-normalizer-bundle.json is always applied in addition (see here) unless the not documented parameter createDefaultTransformationRules is set to false.

  • 🎉2
amotl commented

Thank you René!

So let's keep this issue open as a reminder to improve the documentation correspondingly?

  • 👍1
darxriggs commented

There is more than only the default configuration file attached to this option. If is turned off then also some other automatically generated rules are turned off.