Wrong Parameter Or Argument Colors For Variables

Question

Wrong Parameter Or Argument Colors For Variables

Closed this issue 8 years ago · 7 comments

Variables which are arguments or parameters, have wrong colors in PHP. Regular variable declarations are correct (blue). See the picture below for the problem:

I am using IntelliJ version 2016.1.1

Answer 1 · 2016-05-03T17:29:59.000Z

Which color is wrong?

Here is how it works:

blue - variable declared inside the method
orange - method parameter

Before both were blue, but this was changed to allow easily seeing which variables come from outside of method.

Answer 2 · 2016-05-03T18:45:38.000Z

The color of the method parameter is wrong. The color above is the default color if no color was specified (brownish). All old syntax themes have these issues because Jetbrains changed something with the version 15. I also use the material syntax theme for Jetbrains, it had the same issue (thus the same color for method parameters) but was updated recently.

Answer 3 · 2016-05-03T18:55:05.000Z

Can you please post screenshot of same code with Solarized Dark theme?

Answer 4 · 2016-05-03T18:55:39.000Z

And to compare screenshots from Solarized Light & Solarized Dark from previous PhpStorm versions where it worked as you expect.

Answer 5 · 2016-05-03T19:24:52.000Z

I think we just need to add an element for PHP_PARAMETER.
Like this commit for the material theme.

Answer 6 · 2016-05-03T19:35:33.000Z

Now I realize that commit 8a50bbe by @aik099 actually added the PHP_PARAMETER - but only for Solarized Dark.
I will add it for Solarized Light as well.

Answer 7 · 2016-05-03T22:19:26.000Z

Wow, thanks for the quick fix!