libcitygml 1.4.4 fails to build OSG plugin with OpenSceneGraph 3.2.1

[sebastic]

While updating the libcitygml Debian package I noticed that the osgplugin fails to build, both the osgdb_citygml and citygmlOsgViewer target:

make[3]: Entering directory '/tmp/buildd/libcitygml-1.4.3/obj-x86_64-linux-gnu'
/usr/bin/cmake -E cmake_progress_report /tmp/buildd/libcitygml-1.4.3/obj-x86_64-linux-gnu/CMakeFiles 50
[ 96%] Building CXX object osgplugin/CMakeFiles/citygmlOsgViewer.dir/CitygmlOsgViewer.cpp.o
cd /tmp/buildd/libcitygml-1.4.3/obj-x86_64-linux-gnu/osgplugin && /usr/bin/c++   -DPLUGIN_BIN_DIR=\"/tmp/buildd/libcitygml-1.4.3/obj-x86_64-linux-gnu/lib\" -DUSE_GDAL -DXERCES_STATIC_LIBRARY -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2  -std=c++11 -fPIC -I/tmp/buildd/libcitygml-1.4.3/sources/include -I/tmp/buildd/libcitygml-1.4.3/obj-x86_64-linux-gnu/include    -o CMakeFiles/citygmlOsgViewer.dir/CitygmlOsgViewer.cpp.o -c /tmp/buildd/libcitygml-1.4.3/osgplugin/CitygmlOsgViewer.cpp
/tmp/buildd/libcitygml-1.4.3/osgplugin/CitygmlOsgViewer.cpp: In member function 'bool PickingHandler::printDescriptionOfIntersectedDrawable(const osgGA::GUIEventAdapter&, osgGA::GUIActionAdapter&)':
/tmp/buildd/libcitygml-1.4.3/osgplugin/CitygmlOsgViewer.cpp:50:17: error: 'class osgGA::GUIActionAdapter' has no member named 'computeIntersections'
         if (!aa.computeIntersections(ea, intersections)) {
                 ^
/tmp/buildd/libcitygml-1.4.3/osgplugin/CitygmlOsgViewer.cpp:61:41: error: 'class osg::Drawable' has no member named 'getNumDescriptions'
         if (firstIntersection.drawable->getNumDescriptions() == 0) {
                                         ^
/tmp/buildd/libcitygml-1.4.3/osgplugin/CitygmlOsgViewer.cpp:67:68: error: 'class osg::Drawable' has no member named 'getDescriptions'
         for (const std::string& desc : firstIntersection.drawable->getDescriptions()) {
                                                                    ^
osgplugin/CMakeFiles/citygmlOsgViewer.dir/build.make:57: recipe for target 'osgplugin/CMakeFiles/citygmlOsgViewer.dir/CitygmlOsgViewer.cpp.o' failed
make[3]: *** [osgplugin/CMakeFiles/citygmlOsgViewer.dir/CitygmlOsgViewer.cpp.o] Error 1

make[3]: Entering directory '/tmp/buildd/libcitygml-1.4.3/obj-x86_64-linux-gnu'
/usr/bin/cmake -E cmake_progress_report /tmp/buildd/libcitygml-1.4.3/obj-x86_64-linux-gnu/CMakeFiles 51
[ 98%] Building CXX object osgplugin/CMakeFiles/osgdb_citygml.dir/ReaderWriterCityGML.cpp.o
cd /tmp/buildd/libcitygml-1.4.3/obj-x86_64-linux-gnu/osgplugin && /usr/bin/c++   -DUSE_GDAL -DXERCES_STATIC_LIBRARY -Dosgdb_citygml_EXPORTS -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -D_FORTIFY_SOURCE=2  -std=c++11 -fPIC -fPIC -I/tmp/buildd/libcitygml-1.4.3/sources/include -I/tmp/buildd/libcitygml-1.4.3/obj-x86_64-linux-gnu/include    -o CMakeFiles/osgdb_citygml.dir/ReaderWriterCityGML.cpp.o -c /tmp/buildd/libcitygml-1.4.3/osgplugin/ReaderWriterCityGML.cpp
/tmp/buildd/libcitygml-1.4.3/osgplugin/ReaderWriterCityGML.cpp: In function 'void createOsgGeometryFromCityGMLGeometry(const citygml::Geometry&, CityGMLSettings&, osg::Geode*, const osg::Vec3d&)':
/tmp/buildd/libcitygml-1.4.3/osgplugin/ReaderWriterCityGML.cpp:402:19: error: 'class osg::Geometry' has no member named 'addDescription'
             geom->addDescription(p.getId());
                   ^
osgplugin/CMakeFiles/osgdb_citygml.dir/build.make:57: recipe for target 'osgplugin/CMakeFiles/osgdb_citygml.dir/ReaderWriterCityGML.cpp.o' failed
make[3]: *** [osgplugin/CMakeFiles/osgdb_citygml.dir/ReaderWriterCityGML.cpp.o] Error 1

[jklimke]

Thank you for your feedback. We will have a look at the issue soon