jknecht/baseball-archive-sqlite

G_batting in Batting table

Closed this issue · 2 comments

Thanks for the work you do to make Lahman accessible to us SQLite fans. I noticed that your schema has G_batting and G_old in the Batting table:

CREATE TABLE Batting (
playerID TEXT,
yearID INTEGER,
stint INTEGER,
teamID TEXT,
lgID TEXT,
G INTEGER,
G_batting INTEGER,
AB INTEGER,
R INTEGER,
H INTEGER,
"2B" INTEGER,
"3B" INTEGER,
HR INTEGER,
RBI INTEGER,
SB INTEGER,
CS INTEGER,
BB INTEGER,
SO INTEGER,
IBB INTEGER,
HBP INTEGER,
SH INTEGER,
SF INTEGER,
GIDP INTEGER,
G_old INTEGER
)

while the MySQL does not:

DROP TABLE IF EXISTS `Batting`;
CREATE TABLE `Batting` (
  `playerID` varchar(255) DEFAULT NULL,
  `yearID` int(11) DEFAULT NULL,
  `stint` int(11) DEFAULT NULL,
  `teamID` varchar(255) DEFAULT NULL,
  `lgID` varchar(255) DEFAULT NULL,
  `G` int(11) DEFAULT NULL,
  `AB` int(11) DEFAULT NULL,
  `R` int(11) DEFAULT NULL,
  `H` int(11) DEFAULT NULL,
  `2B` int(11) DEFAULT NULL,
  `3B` int(11) DEFAULT NULL,
  `HR` int(11) DEFAULT NULL,
  `RBI` int(11) DEFAULT NULL,
  `SB` int(11) DEFAULT NULL,
  `CS` int(11) DEFAULT NULL,
  `BB` int(11) DEFAULT NULL,
  `SO` int(11) DEFAULT NULL,
  `IBB` varchar(255) DEFAULT NULL,
  `HBP` varchar(255) DEFAULT NULL,
  `SH` varchar(255) DEFAULT NULL,
  `SF` varchar(255) DEFAULT NULL,
  `GIDP` varchar(255) DEFAULT NULL
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

Is there a reason? Thanks.

These versions of the database are straight conversions from the Access database format. I don't know why the field is there, but it is; so it gets copied.

Honestly, I'm surprised that there is a difference. And now I am rethinking the whole approach.

Thanks for noticing this!

Thanks! It's easy enough to drop the columns on my end. Just was curious.