jkuchar/BigFileTools

getMd5() and getSha1() are unrelated

Closed this issue · 2 comments

getMd5() and getSha1() are unrelated to the problem of getting the filesize of big files and thus should not be part of BigFileTools.

Yes, definitely they are unrelated to getting filesize on huge file. But shoudn't this class be kind of file representation, that can be used insted of lets say http://php.net/manual/en/class.splfileobject.php? Makes sense to extend that class and override non functional parts? Otherwise project name should be changed. Makes that sense? Thanks!

Removed in dev-branch.