jline/jline3

JLine 3.25.1 release source download zip has mismatching maven versions specified

dattasid opened this issue · 3 comments

[jline3-jline-parent-3.25.1]$ cat .mvn/wrapper/maven-wrapper.properties
distributionUrl=https://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.5.3/apache-maven-3.5.3-bin.zip

[jline3-jline-parent-3.25.1]$ grep maven.version pom.xml
pom.xml:        <maven.version>3.6.3</maven.version>

This is causing the error:

[jline3-jline-parent-3.25.1]$ ./build rebuild
Found .mvn/wrapper/maven-wrapper.jar
/user/blah/jline3-jline-parent-3.25.1
Takari Maven Wrapper 0.4.2
Downloading https://repo1.maven.org/maven2/org/apache/maven/apache-maven/3.5.3/apache-maven-3.5.3-bin.zip
... skipped ...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4.752 s
[INFO] Finished at: 2024-04-03T19:57:31Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.4.1:enforce (enforce-maven) on project jline-parent: 
[ERROR] Rule 0: org.apache.maven.enforcer.rules.version.RequireMavenVersion failed with message:
[ERROR] Detected Maven Version: 3.5.3 is not in the allowed range [3.6.3,).

I simply changed the wrapper properties to 3.6.3, but is there a official recommended way to work around this?

Your fix looks good. Could you raise a PR for that ?

PR on master/main branch right?