require finish callback

Question

require finish callback

Closed this issue 9 years ago · 10 comments

no callback of finish view after finished the animation.

Answer 1 · 2015-12-11T20:52:40.000Z

Bump. Without the finish callback, it's hard to enjoy the finish animation because you likely want to show a view as soon as the animation is finished.

Answer 2 · 2015-12-26T19:37:03.000Z

As soon as @jlmd merges my previous PR, I'll be submitting a new one, including this callback and antialias rendering, for discussion ;)

Answer 3 · 2015-12-26T20:00:50.000Z

Thanks @fcouceiro but I have almost finished the callback feature.
Antialias rendering would be nice!

Answer 4 · 2015-12-27T01:03:54.000Z

Cool! It's just a matter of setting the flag. I'll merge the commit in my PR.

Answer 5 · 2015-12-27T09:17:55.000Z

Added animation listener, mark tint and antialias rendering in version 1.1.4
Thanks @fcouceiro for the PRs

Answer 6 · 2015-12-27T15:40:22.000Z

You're welcome ;)

Answer 7 · 2015-12-28T11:43:49.000Z

@jlmd Just updated to the new version. One thing I find useful is having a way to check if the loading was successful or not in the callback. In the way it is implemented we only get the chance to know that the loading is finished. Or do we have any other variable that we can check?

Answer 8 · 2015-12-28T11:52:22.000Z

Yes, that's true. I should add a parameter to the callback indicating if the loading was successful.
I will do it soon.
Thanks!

Answer 9 · 2016-01-23T20:27:35.000Z

Great library - any update on attaching a success flag to the callback, Jim? Thanks!

Answer 10 · 2016-01-26T21:29:11.000Z

I've just added a success flag in onAnimationEnd listener.
It's released in version 1.1.5.