jlokimlin/fishpack

assert_equal abs(first-second) > 0

donnaaboise opened this issue · 0 comments

I am wondering why the assertion assert_equal is defined as TRUE when abs(known_error - discretization_error) > 0. This allows all examples to PASS, when in fact, the difference is non-zero.

It seems that abs(known_error - discretization_error) < tol, for some small value tol (e.g. tol = 1e-12) would make more sense.