jlong/sass-bootstrap-defunct

Incorrect .navbar-nav margin

albv opened this issue · 2 comments

albv commented

In _navbar.scss:

.navbar-nav {
  margin: ($navbar-padding-vertical / 2) -$navbar-padding-horizontal;
  ...
}

In original LESS version it supposed to set both horizontal and vertical margins, but in SASS it's simply subtract values. So I think it should be:

.navbar-nav {
  margin: ($navbar-padding-vertical / 2) (-$navbar-padding-horizontal);
  ...
}
m5o commented

confirmed, with variables, the values are subtracted, would you like to add an pull request for this?

albv commented

@m5o Oh, you fixed it already. Thank you!