oauth
juliangruber opened this issue · 11 comments
so you don't need to insert your password
wowow looks like @maxogden has a thing: https://www.npmjs.org/package/github-oauth can I just swap out ghauth for github-oauth?
looks like you're already sending the oauth2 token: https://github.com/jlord/offline-issues/blob/master/src/index.js#L15
Aaaaah now I get what's going on, the cli asks for username and password in order to create a token for you. It would be nice to inform the user, and/or provide the option to enter a token manually.
The option to enter a token manually would be great! Those are easy to generate from GitHub's settings page.
Also, apparently there is a new version of ghauth which fixes the problems with trigger the SMS 2fA, so I'll update that first and see how it does.
Hrm, the version of ghauth that fixed this was .2 and the package.json here had ^0.1.1 so it should have allowed 0.2.0 and above, right?
@feross do you know what version of ghauth you got when you installed offline-issues?
Awesome!
On Tuesday, September 30, 2014, Jessica Lord notifications@github.com
wrote:
Also, apparently there is a new version of ghauth which fixes the
problems with trigger the SMS 2fA, so I'll update that first and see how it
does.—
Reply to this email directly or view it on GitHub
#10 (comment).
Feross | blog http://feross.org/ | webtorrent http://webtorrent.io/ |
studynotes http://www.apstudynotes.org/
Either way, I updated the package.json to require ghauth at ^0.3.1, which is the current version.
Let me know if things work. 🎉
Nope. ^ has unintuitive behavior for 0.x versions. ^0.1.1 allows < 0.2.0.
Even weirder, ^0.0.4 only allows 0.0.4.
I bet bumping to ^0.2.0 will fix the issue!
On Tuesday, September 30, 2014, Jessica Lord notifications@github.com
wrote:
Hrm, the version of ghauth that fixed this was .2 and the package.json
here had ^0.1.1 so it should have allowed 0.2.0 and above, right?@feross https://github.com/feross do you know what version of ghauth
you got when you installed offline-issues?—
Reply to this email directly or view it on GitHub
#10 (comment).
Feross | blog http://feross.org/ | webtorrent http://webtorrent.io/ |
studynotes http://www.apstudynotes.org/
@feross Ah, yeah, I just looked at the docs and saw I'd understood it wrong:
^1.2.3 := >=1.2.3 <2.0.0
^0.2.3 := >=0.2.3 <0.3.0
^0.0.3 := >=0.0.3 <0.0.4
This feature would be perfect, those of us with Two-Step enabled can't use the app!
2FA should be working with this and I've updated a bunch of dependencies today so hopefully it's ok to close this out for now. 🍕