Month tab is usually wrong

Question

Month tab is usually wrong

Closed this issue 6 years ago · 16 comments

mwsasser commented 6 years ago

When I select Today the calendar itself is correct but the month tab is last month.

The bug started around Thunderbird 52.4.0 & Lightning 5.4.4. I am now up to 5.7.0 & 5.4.7.

Answer 1 · 2018-04-25T20:23:14.000Z

Which version of addon do you have? I hope that I fixed this issue in last version.

Answer 2 · 2018-04-26T00:16:06.000Z

It's version 2.0. I don't see an update available. Is it on a different site?

Answer 3 · 2018-04-26T18:38:24.000Z

No, v2.0 is the last version I released. I just hoped that I fixed the bug already... can you please describe concrete steps to reproduce the bug? And also the settings of the addon?

Answer 4 · 2018-04-27T15:09:40.000Z

If I open the calendar, the highlighted tab is the previous month.
If I click a future month, the calendar is correct but it highlights the previous month's tab.

Answer 5 · 2018-09-13T21:18:11.000Z

Yes, !! This is still happening. I'm on version 2.1 and Thunderbird 60. Extremely annoying. Here is the screen shot. After selecting correct month tab it jumps right back and highlights wrong tab.Could you please fix it?

Answer 6 · 2018-09-13T21:27:12.000Z

Agreed, it's still messed up. Please fix it!

Answer 7 · 2018-09-17T13:41:11.000Z

Sorry guys, I am not able to replicate that behavior -- I do not say that the bug does not exist, just that it is extremely difficult to fix it if I can't see it. I made a fresh install of Thunderbird 60 with Lightning and my addon and it worked OK.

Does the addon show correct month when you change the date using arrow buttons over the tabs?
Do you have some other addons installed (besides lightning and my addon)?
What is your timezone?
Is the bug only random or does it happen all the time, or does it happen after particular action, or does it affect only a concrete month?

Answer 8 · 2018-09-18T13:08:08.000Z

Hopefully my email response will help you find that pesky bug.

Answer 9 · 2018-09-19T18:42:11.000Z

I did not received any email yet - please resend to jlx@seznam.cz.

Answer 10 · 2018-10-30T18:43:49.000Z

I can confirm this bug, it only occurs when the Lightning Calendar is configured to use UTC-x timezones.

I created a PR (#5) that resolves this issue, with major changes to the code though.

Answer 11 · 2018-10-31T12:08:50.000Z

Nice. When can we see the update @jlx84?

Answer 12 · 2018-10-31T15:48:34.000Z

Thank you @tunefish. I expected that the bug is time-zone related but I did not have time to fix it yet.
I made a xpi package for testing purposes here: https://github.com/jlx84/lightning-calendar-tabs/releases/tag/2.2-beta (Download it in FF using right mouse button and select "Save link as")
You can install the addon manually in Thunderbird addon manager (button with gear icon). I will test it on my Windows PC tomorrow and then I will release it.

Answer 13 · 2018-11-01T18:57:15.000Z

I just uploaded the addon to mozilla addons page.

Answer 14 · 2018-11-02T12:08:33.000Z

Well that's odd. "This add-on is not compatible with your version of Thunderbird."

Answer 15 · 2018-11-02T12:22:29.000Z

Addon is compatible with Thunderbird 59 and 60. I had to make some changes to make it compatible with new Thunderbird versions earlier this year. Older Thunderbird versions are not supported since version 2.1 of my addon. This version is 2.2.

Answer 16 · 2018-11-08T15:58:00.000Z

With today's Thunderbird update to 60.3.0, I can confirm the bug is gone.

Thanks for fixing it!