[parsing] - when generating tbpl urls, only use pgo for aurora and beta

Question

[parsing] - when generating tbpl urls, only use pgo for aurora and beta

jmaher opened this issue 11 years ago · 9 comments

an example is this-

we generate:

Answer 1 · 2014-05-09T13:55:01.000Z

we generate:
https://tbpl.mozilla.org/?tree=Mozilla-Aurora&fromchange=caf1a925d7db&tochange=9b62596f6151&jobname=Windows%207%2032-bit%20mozilla-aurora%20talos%20tp5o

we want to generate:
https://tbpl.mozilla.org/?tree=Mozilla-Aurora&fromchange=caf1a925d7db&tochange=9b62596f6151&jobname=Windows%207%2032-bit%20mozilla-aurora%20pgo%20talos%20tp5o

but we don't have pgo for osx builds, so this is for branches = [Mozilla-Aurora, Mozilla-Beta] and platforms =[linux, linux64, winxp, win7, win8]

Answer 2 · 2014-07-02T07:17:12.000Z

Hi,
Can you please elaborate a little bit more on this?
And I have a few things to discuss with you, so is it okay if I send you a mail at
jhamer@mozilla.com?

Thanks.

Answer 3 · 2014-07-02T13:37:12.000Z

Hi,
I received your mail and have sent you one too. Please have a look. Also a little elaboration on this Issue would be great.

Thanks.

Answer 4 · 2014-07-02T13:39:36.000Z

Hi Kaustabh,

At Mozilla we build opt (optimized), debug (with debug symbols, etc.) and pgo (program optimized). What we release as final releases is a PGO build. For our non trunk/integration branches we only build PGO.

With that background, we have two different branches for our builders, for inbound:
mozilla-inbound-non-pgo
mozilla-inbound

but this translates to the tbpl view as:
mozilla-inbound
mozilla-inbound-pgo

That is sort of flip flopped, but keep reading. On our aurora, beta, release branches we only build PGO, so the links to tbpl need to be mozilla-aurora-pgo and mozilla-beta-pgo.

For the branches that are listed in alert-manager database, if they have non-pgo in the branch name, then tbpl should load it fine as the branch name.

That is the background, the example above should help show what specific details need to be changed when the platform doesn't have a non-pgo in it.

Answer 5 · 2014-07-02T14:47:40.000Z

Thank You.
And one more thing. Except for the url, the contents of the two links are the same. So how do I know that these are contents from two different URL?

Answer 6 · 2014-07-02T14:51:00.000Z

everything will look to be the same except for the additional %20pgo in the case when we don't have a non-pgo.

Answer 7 · 2014-07-02T14:52:36.000Z

Thanks. I am unto it. I will let you know if I face any more problems.

P.S. : Did you get my mail?

Answer 8 · 2014-07-02T15:45:53.000Z

Hi,
I think I have solved the issue. I have created a pull request. Please do have a look.
Thanks.

Answer 9 · 2014-07-02T20:04:11.000Z

this is fixed and deployed! Thanks for looking into this.