history : missing reply to concurrence

7:33 juris: btw one other thing. something we noticed about tasks defined in concurrence blocks
07:34 juris: when parsing history, it doesn't seem like the 'reply' for the last task to exit the block is ever received...
07:38 jmettraux: juris: maybe it's received after the reply to the concurrence
07:38 jmettraux: kellyp: hello and welcome to #ruote
07:40 juris: would it still be registered in the history with an action == 'reply' ?
07:40 jmettraux: kellyp: glad to read that
07:40 jmettraux: juris: if you see other "reply" then yes, any attributes set on your "concurrence" ?
07:50 juris: we pull all the entries that are action =~ /reply|dispatch/ - we do set some variables within those tasks in the concurrence
07:50 juris: (is that what you meatn by attributes?)
07:51 jmettraux: sorry, I meant "concurrence do" vs "concurrence :count => 1, :remaining => :forget do"
07:51 jmettraux: attributes of the expression
07:51 juris: ah... one of them we do:
07:51 juris: concurrence :merge_type => :mix, :over_if => '${issue}', :count => 2 do
07:53 jmettraux: by default, the remaining branches get cancelled, I'd have to double check, but they might not reply (especially since the concurrence is over and gone)
07:54 jmettraux: :count => 2 means that after 2 replies, the concurrence is over
07:54 jmettraux: :over_if => ... could terminate the concurrence even sooner
07:55 juris: so that means they wont have an entry in history?
07:56 jmettraux: it means the reply of the remaining branches to the gone concurrence won't make it in the history
07:56 juris: what we're seeing is that the reply of the task that causes the exit from the concurrence block does happen. it's just that
07:57 jmettraux: that's the right behaviour
07:57 juris: it does not seem like there is a history entry for it.

env : ruote 2.1.11

https://gist.github.com/88a8be8675db9e638cc1

quick piece of Ruby to reproduce supposed issue : https://gist.github.com/1011503

Closed by f25fe71

Feel free to re-open (with enhanced explanation) if the fix doesn't cut it.

Backporting to 2.1.11 simply requires to add this line

ruote/lib/ruote/exp/fe_concurrence.rb

Line 200 in f25fe71

workitem = Ruote.fulldup(workitem)

Thanks !

I don't have the permission to reopen, so commenting instead (please consider it open again):

I've backported the fix to 2.1.11 and it does not seem to work. I still don't see the reply entry in history of some of the participants within a concurrence block.

Here's how how we've defined the process that is exhibiting the issue:

cursor do
  unset 'issue'

  concurrence :merge_type => :mix, :over_if => '${issue}', :count => 2 do
    cursor do
      publisher :task => 'publish'
    end

    cursor :if => '${team.audio_producer}' do
      audio_producer :task => 'record voice over'
      stop :if => '${issue}'

      audio_producer :task => 'review voice over'
      rewind :unless => '${review} == approve'
    end
  end

  content_editor :task => 'review issue', :if => '${issue}'
  rewind :if => '${issue}'
end

In the above, a reply entry for publisher_publish will not be in history.
Here's how we are pulling the entries:

Workflow.engine.context.history.by_process(wfid).
  select{ |x| %w(reply dispatch dispatch_cancel).include? x['action'] }

Thanks.

Hello,

I think I have an explanation :

https://gist.github.com/1026311

which outputs (ruote 2.1.11 and ruote 2.2.1) :

----------------------------------------
"receive"
[:reply_to, "0_0_0_0_0"]
[:reply_from, "0_0_0_0_0", "publisher"]
----------------------------------------
"reply"
[:reply_to, "0_0_0_0"]
[:reply_from, "0_0_0_0", "publisher"]
----------------------------------------
"reply"
[:reply_to, "0_0_0"]
[:reply_from, "0_0_0_0", "publisher"]
----------------------------------------
"reply"
[:reply_to, "0_0"]
[:reply_from, "0_0", "publisher"]
----------------------------------------
"reply"
[:reply_to, "0"]
[:reply_from, "0_0", "publisher"]

Sorry, it's a "receive" and not a "reply".

I'm closing the issue for good. If you feel further discussion is needed, feel free to use the mailing list at http://groups.google.com/group/openwferu-users so that the conversation doesn't get lost in this issue tracker.

Best regards,

John

Thanks. I posted a question the list.

The gist of which:
What's the difference between receive and reply entry in History? Does
receive mean, the reply was received, and the task is in process or
completed? Is it a "more recent" event than reply?

Thanks.

On Tue, Jun 14, 2011 at 6:33 PM, jmettraux <
reply@reply.github.com>wrote:

Hello,

I think I have an explanation :

https://gist.github.com/1026311

which outputs (ruote 2.1.11 and ruote 2.2.1) :

"receive"
[:reply_to, "0_0_0_0_0"]
[:reply_from, "0_0_0_0_0", "publisher"]

"reply"
[:reply_to, "0_0_0_0"]
[:reply_from, "0_0_0_0", "publisher"]

"reply"
[:reply_to, "0_0_0"]
[:reply_from, "0_0_0_0", "publisher"]

"reply"
[:reply_to, "0_0"]
[:reply_from, "0_0", "publisher"]

"reply"
[:reply_to, "0"]
[:reply_from, "0_0", "publisher"]

Sorry, it's a "receive" and not a "reply".

I'm closing the issue for good. If you feel further discussion is needed,
feel free to use the mailing list at
http://groups.google.com/group/openwferu-users so that the conversation
doesn't get lost in this issue tracker.

Best regards,

John

Reply to this email directly or view it on GitHub:
#29 (comment)

Juris Galang