jmhobbs/cultofthepartyparrot.com

Add light/dark mode override

Abhishek-465 opened this issue · 14 comments

I can add darkmode with the help of javascript.

Hi @Abhishek-465!

We do have a dark mode CSS theme which uses @media (prefers-color-scheme: dark), but if you'd like to add a toggle or something to allow folks to change between light and dark mode, go for it!

Ok then i am ready for it.

i want to contribute here please give me permission

Hi @AnshuWorld you're more than welcome to have a try, PR #636 appears abandoned unfortunately.

VBPMP commented

please, assign me this issue

Hi @AnshuWorld you're more than welcome to have a try, PR #636 appears abandoned unfortunately.

Please share me the link also tell me what I have to do

@AnshuWorld #636 has details on what needs to happen. Essentially, it should respect prefers-color-scheme but allow for an override by JavaScript.

Hi @jmhobbs , Is this issue still open?
I would like to contribute to this. Please send the necessary links and details along with it.

Else Please let me know about any other isuue. Thanks

Hi @YashX777, yep, this is still open. It should be more "add dark mode toggle", since we have a dark mode we just don't have a way to override the prefers-color-scheme

Can you share all details pertaining to this issue?
And officially please assign me this .

@YashX777 There's notes on #636 on roughly what I'd like. Somewhere on the page a toggle to switch light/dark theme, as well as some memory of that choice in browser storage. Something small preferably!

I tried reading the README and deploying it, but it's showing a lot of errors. Is there any other file explaining it step by step?

@YashX777 to do a local build you have to install a lot of things:

It would be difficult, but you could open a PR and make changes there, and Netlify will rebuild them for you. That would be a slow way to work though, it might be worth the effort to install the dependencies.

I will try to make the install instructions better as well and provide some more guidance in the README

I added more details in #656, as well as some more flexible install checks for the JS based tools. 👍