jmhodges/rchardet

CharDet.detect changes the encoding of the string

mou opened this issue · 6 comments

mou commented

This call mutate string, but there is no indication of this behavior.
In method feed of UniversalDetector used force_encoding, but this method dosn't use clone string and dosn't change encoding back.

jmhodges commented

I'm not quite understanding you.

There are no calls to force_encoding in this codebase, so this criticism (as I understand it) doesn't apply.

To be clear, this library is not known (to me) to work in ruby 1.9.

jmhodges commented

I'm open to patches for 1.9 support that are backwards compatible to 1.8.

mrbrdo commented

You still use 1.8? Since you're asking for patches that are backwards compatible with unsupported/dead Ruby version. Confused :S

jmhodges commented

Yes, my workplace has the majority of its ruby code in our fork of 1.8 with an improved GC, and I no longer work in ruby day-to-day or in my spare time. There's been no need for me to upgrade.

Patches welcome!

mrbrdo commented

I just wanted to say that maybe it doesn't make sense to demand 1.8 support if someone decides to make a patch, considering it's end-of-life.
I would gladly help but at the moment I'm too stomped.

grosser commented

if you can reproduce this or have a fix or failing test, please reopen

1.4.1 supports 1.9+ now