jmjuanes/siimple

Can legacy color be manteined

Dacker15 opened this issue · 6 comments

Dacker15 commented

I read the documentation and I saw that the support for this color will be dropped soon.
Beacause I use it in my project and I don't want fork the repository to receive package update,
I want to know if it is possible to keep it and realize helper.
If it is not possible, can I know why they will be removed?

Thanks

jmjuanes commented

Hello!

The idea is that legacy color helpers will be moved to @siimple/colors package, and we will keep in the core module only basic color helpers. Legacy color modifiers will be removed, and in the core module we will keep only basic color modifiers (primary, secondary, error, warning and success).

Question: are you using color helpers (siimple--color-purple) or color modifiers (siimple-btn--purple)? Or both? Sorry, I forgot that legacy colors are not available for helpers, so I think that the point here is that you are using color modifiers like siimple-btn--purple, right?

Dacker15 commented

Sorry, but I didn't understand very well.
Will legacy color stay available in another package?

jmjuanes commented

Sorry, but I didn't understand very well.

There are two types of color class names: "color helpers" and "color modifiers".

  • Color helpers were introduced in v3.1.0 and are documented here: https://docs.siimple.xyz/helpers/colors.html .
  • Color modifiers are class names used to change the color of some siimple elements, for example the button or the tip. Color modifiers usually change both background and text color. For example, siimple-btn--red will set in the button the background color to red and the text color to white.

Will legacy color stay available in another package?

Yes and no. Our idea in the @siimple/colors package is to keep only the legacy colors (and another new colors) as helpers, so you can change the text color and background color of any html element with siimple--color-* and siimple--bg-*.

But in this package will not include class names like siimple-btn--red or siimple-tip--orange, and you need to keep these class names for your project. Is that true?

Dacker15 commented

Thanks for your answer. I only need helpers so if they are available in @siimple/colors, it will be ok.
Could I ask you when they will be removed?

jmjuanes commented

Thanks for your answer. I only need helpers so if they are available in @siimple/colors, it will be ok.

Perfect!!

Could I ask you when they will be removed?

Version 4.0.0 of @siimple/css won't include legacy colors. But at this moment I don't know the exact date.

Dacker15 commented

Thanks for information