jmplonka/InventorLoader

Update to new FreeCAD AddonManager metadata schema

luzpaz opened this issue · 14 comments

https://github.com/jmplonka/InventorLoader/blob/master/metadata.txt needs to be migrated to package.xml and modified

Done - plaese, check if valid.

@jmplonka well done! Are there any 3rd party dependencies necessary for InventorLoader ?
The answer is yes. See https://github.com/jmplonka/InventorLoader#prerequisites
image

@chennes can we import these with the Addon Manager?

Note: Here is the current package.xml

@jmplonka in the meanwhile the metadata.txt file can be removed 😉

@luzpaz actually that's not true, you want to keep that around for the

[dependencies]
pylibs=olefile,xlrd,xlwt,xlutils

The rest of it is ignored, but the Python deps are still read from either requirements.txt or metadata.txt. And yes, the Addon Manager will offer to install the missing dependencies, as long as they are on the approved list. I'll look at adding these.

Oh sh*t, sorry about that!

Oh yeah, right! This WB was one of my test cases, of course the deps already work. I totally forgot.

Fixed in #55
@chennes having an issue loading the InventorLoader in the addon manager. It's looking for a main branch when the default is master
image

OS: Ubuntu Core 20 (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.20.27571 (Git)
Build type: Release
Branch: master
Hash: 0bbc253ddee6801770c78e011c5201b7c2c36080
Python 3.8.10, Qt 5.15.3, Coin 4.0.0, OCC 7.5.2
Locale: English/United States (en_US)
Installed mods: 
  * ToolbarStyle
  * stickframe
  * sheetmetal 0.2.49
  * Behave-Dark-Colors 0.0.1
  * Curves 0.3.0
  * Ship
  * BIM 2021.12.0

Can this be closed?

Who can tell? Yes from my side :)

@chennes can we close this? I mean, does the InventorLoader addon work for you. I can't test atm since I screwed up my FC build.

Yes, InventorLoader's metadata seems fine, it displays and installs without issue, including its stated dependencies.