jmrivas86/django-json-widget

v1.1.0 seems to be trying to use incorrect static files

Closed this issue · 7 comments

dkarchmer commented
  • django-json-widget version: v1.1.0
  • Django version: 3.1
  • Python version: 3.7
  • Operating System: Linux

Description

Just upgrade to Django v3.1 and with it, to django-json-version 1.1.0. After I run collectstatic, I get the following two files under my statics directory

  • dist/jsoneditor.min.css
  • dist/jsoneditor.min.js

which seems to be the same as version v1.0.1.

The problem is that when running the server, the page fails to load. Looking at the browser console, I can see it is erroring out trying to find dist/jsoneditor.css and dist/jsoneditor.js (see how it is not the .min. version)

image

What I Did

I didn't do anything different, so unless something changed in the way Django 3.1 works, this may be a problem with the new v1.1.0 version

dkarchmer commented

Seems like the bug was introduced here:

1e7b047#diff-c92ce623c95bf852173e45c7aa3fdbecb97463b16a1a9a6834a2d9edd87e5a8dR11

See how the defaults are no longer .min files

dkarchmer commented

Would be nice to add the optional (not so optional with this bug) settings to the README:

JSON_EDITOR_JS = 'https://cdnjs.cloudflare.com/ajax/libs/jsoneditor/9.1.9/jsoneditor.min.js'
JSON_EDITOR_CSS = 'https://cdnjs.cloudflare.com/ajax/libs/jsoneditor/9.1.9/jsoneditor.min.css'
  • 👍1
pmtarantino commented

Hello. I found the same problem. Thanks for reporting it @dkarchmer. I revert it back to version 1.0.1.

illing2005 commented

We're having the same issue

ash-raph commented

same issue 😢

jmrivas86 commented

Fixed in version 1.1.1 by @StevenMapes 👏 in #52