jmrozanec/cron-utils

Spring cron definition should allow L, W, LW

esommars opened this issue ยท 9 comments

According to this release: https://spring.io/blog/2020/11/10/new-in-spring-5-3-improved-cron-expressions
The day-of-month should support L, W and LW.

@esommars thank you for the heads up. We will check for this functionality, and make sure is supported. Best!

@jmrozanec Could you help guide how support could be added?

Am I correct that it's as easy as marking the SPRING CronDefinition for day of the month to now support these using supportsL() and supportsW()?

@korthout should be that easy ๐Ÿ˜„ We will add the functionality marking whether the desired Spring version is before Spring 5.3 or not and release a new version with this change today EOD. Thank you for drawing attention to this issue! ๐Ÿ˜„ And for using cron-utils! ๐Ÿ˜Ž

@jmrozanec Wow, that's a fast response! ๐Ÿ˜„

And that's great to hear! Let me know if you need my help in any way. Otherwise, thanks for this!

@korthout thanks! ๐Ÿ˜„ You are welcome!

@korthout the feature was added, and a new version (9.1.8) was released with it. We provide full compliance with the features listed in the new Spring cron version, including nicknames. We hope you find it useful! ๐Ÿ˜„ Any feedback will be appreciated!

@esommars, the feature was added, and a new version was released (9.1.8)! :) Thank you for drawing attention to this!

@esommars, the feature was added, and a new version was released (9.1.8)! :) Thank you for drawing attention to this!

Very nice! :)

This is great! Thanks a lot ๐Ÿš€

Any feedback will be appreciated!

I'll make sure to reach out if we run into any issues.