jnavila/plotkicadsch

[WINDOWS] Internal diff can't resolve git commit

abdallahfalou opened this issue · 2 comments

Hi,

I can successfully diff working vs HEAD by running plotgitsch -i, as well as any two revisions using external tools (e.g. plotgitsch HEAD~10 HEAD~3). Fails to run with internal tools whenever revisions are explicitly written plotgitsch -i HEAD~10 HEAD~3 with the following message:

internal diff and show with HEAD~10 between Git rev HEAD~3 and file system .
The system cannot find the file HEAD~10.
Errored with code 1

I also get a pop-up saying:

Windows cannot find 'HEAD~10'. Make sure you typed the name correctly, and then try again.

Same issue if I specify commits explicitly using a short hash.

Unfortunately, when using -i option, you have to specify the browser name, e.g. -ifirefox or -ichrome. Your error is coming from the fact that the command interprets the first argument after the -i option as the name of viewer, here HEAD~10, as described in the output:

internal diff and show with HEAD~10 between Git rev HEAD~3 and file system .

I think I should make the name of the viewer mandatory for the -i option, because right now, it is not consistent depending on the number of arguments.

Worked indeed, thanks for clarifying!

I think allowing a default is useful, perhaps with a different argument (-I?).