jnolis/ggirl

Sunset/sunrise plot should be flipped

robinsones opened this issue · 1 comments

I feel like naturally the sunrise would be on the top and sunset on the bottom, with time going (top to bottom) 12 am 6 am 12 pm 6 pm.

So I looked into this and the requirements of:

  • Flip a time axis in ggplot2
  • Have it work within a package

Seem outside the scope of what ggplot2 can actually handle. The closest I found was: https://gist.github.com/mikmart/bfbf62839fbdd162b4b88e6d43e0c858 which doesn't work within a package because it seems to require scales in the namespace, and also by switching from a ggplot2::scale_y_datetime to a ggplot2::scale_y_continuous breaks other stuff. I'm sure it's possible to solve this but it would take a bunch of hours and be pretty brittle which I don't think is worth the value of the feature.