Track lock's lifetime in Lock instances

Question

Track lock's lifetime in Lock instances

akhilman opened this issue 7 years ago · 6 comments

We can pass lock's timeout to it's constructor and check is timeout reached in lock.valid attribute.

Answer 1 · 2018-01-10T20:39:46.000Z

My feeling is that this is really dangerous. In one hand it would be great but to track the timeout by having a timer I feel it can lead to problems since in can go out of sync with the real lock. Don't you think?

Answer 2 · 2018-01-10T21:19:15.000Z

I thing setting timeout to moment when Aioredlock.lock() was called + lock_timeout - drift is ok.
Or I can implement lock_manager.is_valid(lock) to check is lock really valid.

Answer 3 · 2018-02-02T06:20:43.000Z

May be fixed in testing branch.

Answer 4 · 2020-01-08T01:54:23.000Z

With #54 Aioredlock now can automatically extend lock lifetime.

Answer 5 · 2020-07-07T16:57:34.000Z

It looks like the is_valid feature has been implemented, can this ticket be closed?

Thanks,
Daniel

Answer 6 · 2020-07-07T17:14:12.000Z

May you also add is_locked() method to https://github.com/joanvila/aioredlock/blob/master/aioredlock/lock.py ?