joaomgcd/JoinChrome

Css is messed up on older chrome version because of use of css var()

Closed this issue · 8 comments

Installed join on a new pc today, the css is all weird, colours are missing:

image

inspected the css:

image

Can see you're using var(), this is a University PC so chrome 47 is the newest version and i cant do a whole bunch about it, maybe a bit early to be using what's still an experimental feature? I appreciate 47 is a pretty old version of chrome as chrome versions go, but it's still only 6 months old so maybe a fallback would be appropriate.

Either way, reporting so you know.

J

Yup. I've been considering switching it back for a while now because it is jumping the gun a little. Your issue request may be the impetus necessary. Thanks!

That's 5 versions and 8 months :( makes me sad that places are still doing this with a browser. You'd figure the security risk would outweigh anything else.

Fallback wouldn't really exist other than declaring the color again as far as I know and obviously that defeats the purpose. Personally I'm not 100% sold on the use of native vars yet (probably never on syntax) and would much rather use a preprocessor for variables. My vote would be SASS. However the projects not that big so good ole' fashioned hex is not that big a deal.

How it renders is pretty crazy.

Kevin or Tom, are you on it? :) Or should I?

I can do it if you want

On Tue, Aug 2, 2016 at 4:43 AM, João Dias notifications@github.com wrote:

Kevin or Tom, are you on it? :) Or should I?


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#21 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAfIEolbynmFp7R0KDB6yW3rc6L7JTl-ks5qbwMegaJpZM4JZx1m
.

Go ahead with it I'm unfortunately on a trip right now

Ok Tom, I appreciate it if you can do it :) I always like to take care of other non-visual stuff. Thanks in advance!

Ok should be all set

Thank you very much! :) Merged