joaomgcd/JoinChrome

Image Preview is hidden behind the attach and emoji button in popout view

Closed this issue · 5 comments

kienD commented

The image preview is hidden behind the attachment and emoji buttons.

See Below:

image_preview

@tommyent any suggestions on how to make this look better? :D Thanks in advance

Simple

screen shot 2017-05-24 at 2 13 38 pm
or a bit more

screen shot 2017-05-24 at 2 21 21 pm

kienD commented

@tommyent,

I like the second one since it provides a better view of the image and gives the user an easy way to remove the image.

The second method also leaves the developer more room to iterate on, as it's easier to expand the amount of photos one can add to a chat before sending the image whereas the first method will run out of space quite quickly.

I think another possible improvement would be adding some sort of label that states that this is a preview as well.

Thanks guys!

@kienD the red x I think would be enough to indicate that it's a preview. The second option is my favorite but the first one is just a matter of stripping out some css so it can be done in less than a minute.

One other thing I was thinking about is I think I should have removed the chat bubble pointer.

I have to say, I really don't like the second one just because I think people will be confused thinking that the message was already sent.

Here's how it's going to look like in the next release:
closemms

Hope this helps and thanks for all the help! :)