Not working in Brave (new chrome based browser)
jeroenev opened this issue · 12 comments
when installing the extension, it's not possible to login (login page doesn't appear)
also when checking the settings page none of the buttons/actions/tabs respond when clicking on them
Sorry, Join was not meant to be used on browsers other than Chrome so I can't vouch for it working there...
Too bad, it works fine in Vivaldi though, which is also a chrome based browser
Other extensions i use work fine in brave, seems like this is the only exception atm
But i guess it's up to Brave devs to fix compatibility, will report it there
I think only the beta/dev of Brave is currently Chromium. I've tested and it worked fine for me.
@tommyent if you currently download the stable version it's already chromium based, though the old muon based version won't automatically update to the chromium base atm as far as i'm aware
I'll test the beta later to see if it's just an issue in the current stable version
Tested extension again on stable, seems to work
Not sure what caused it to break completely when i tried it before, but it seems to be fixed, so this ticket can stay closed 😃
Brave uses Chromium (Chrome) so I'd appreciate if you can try to fix this issue.
On diagnostics page, I get alert() at step 2 Testing registration on Join's server...:
Unknown error: TypeError: Cannot read property 'where' of null
getting similar error, but the sending push to server... also gives an error for me
however, pushing tabs to my phone seems to work fine
EDIT: on linux i don't get the registration error
everything seems to work fine, except the two receiving pushes checks don't work
chrome://gcm-internals shows state "INITIALIZED" instead of "CONNECTED"
maybe that's the cause?
is there no backup to use if GCM doesn't work?
that could be a major roadblock for people that use anything but googles native chrome browser, or people that use an android device without play services
@dogancelik @jeroen7s Brave disabled both GCM and FCM (Oct/Nov) so currently it will no longer work with Brave.
Just today opened my browser and the test notifications which failed yesterday have arrived
in diagnostics the "Receiving Push from server..." no longer fails,
only the "Receiving Push with GCM key..." still fails, but that's to be expected.
The important part is that receiving pushes works now 👍
Good news: Join now works in Brave 🎉
You just need to enable the "Google Services for Push Messaging" setting in Brave for it to work. See brave/brave-browser#2408 (comment)
After you've done this, all the tests in the diagnostics tab will pass:
Tested on Brave Version 1.1.23 Chromium: 79.0.3945.88 (Official Build) (64-bit).
Nice :D Thanks for letting us know!