joaomoreno/deemon

Return status-code 1 when process is killed

hediet opened this issue · 4 comments

When this happens:

treekill(child.pid);

This should not exit with status code 0, as the process was killed unexpectedly:

process.exit(0);

This is probably the cause of microsoft/vscode#144246 .

You mean something like this? #5

Maybe all we need is the propagation of the exit code, regardless of when it happens, no?

Yep. I guess when deemon receives the kill signal and kills the process, the process will exit with a non-zero exit code.

If that one is forwarded, it will work.

Released in deemon@1.7.0

Awesome, thank you!