Return status-code 1 when process is killed
hediet opened this issue · 4 comments
hediet commented
When this happens:
Line 79 in cf0bdd8
This should not exit with status code 0, as the process was killed unexpectedly:
Line 95 in cf0bdd8
This is probably the cause of microsoft/vscode#144246 .
joaomoreno commented
You mean something like this? #5
Maybe all we need is the propagation of the exit code, regardless of when it happens, no?
hediet commented
Yep. I guess when deemon receives the kill signal and kills the process, the process will exit with a non-zero exit code.
If that one is forwarded, it will work.
joaomoreno commented
Released in deemon@1.7.0
hediet commented
Awesome, thank you!