Request to Not Rely on GitHub Releases
wangweixuan opened this issue · 2 comments
Now we use GitHub Releases to download assets, which in my opinion is not to be relied on. It almost always fails in certain regions. Even if it can be accessed, the speed is extremely slow. This has made my experience of building VS Code full of pain.
So I suggest to provide alternative ways for downloading. Perhaps the default option is to download direct from github.com/electron/electron/releases/download/.... While I may specify a mirror in the environment variables, or as a download option. In that case the reliability of this package will be visibly increased.
So this was merged but shouldn't github-releases-ms be removed from package.json as well? Latest release (1.19.2) did not remove the dependency and so the problem persists.
Closing this as won't fix. Recommended way to depend on Electron can be found here: https://electronjs.org/docs/tutorial/first-app