joaomoreno/gulp-atom-electron

Fails to with no error after updating packages

willcalderbank opened this issue · 3 comments

willcalderbank commented

Hi,
Sorry that im unable to find the route cause but after hours of looking i'm hoping that someone will know the solution off the top of their head.

Everything was working fine until the beginning of the week, after running npm install a package must of updated, now gulp-atom-electron fails stopping gulp from running.

The resource/app file is created and my apps contents copies across then build stops (doesnt fail, just stops)

Any ideas?

Sorry again.

willcalderbank commented

After some more digging found the problem lies in the gulp-rename dependency, works fine with v1.2.2 but the latest (released only 10 days ago) v1.2.3 doesn't seem to forward on the stream.

From package.json: "gulp-rename": "^1.2.0" Allows gulp-rename to update, breaking gulp-atom-electron.

Including "gulp-rename": "1.2.2" in the applications package.json fixes the issue.

joaomoreno commented

Yup I could reproduce this. I will lock the dependency and release a patch version.