joboccara/pipes

tests: missing Makefile (or equivalent)

Closed this issue · 5 comments

rnsanchez commented

It should greatly assist on testing the code with the inclusion of something like a Makefile for building the test cases. Direct benefits include:

  1. Making sure the code compiles correctly on supported platforms;
  2. Making sure the code is functioning (i.e., test cases run as intended);
  3. Catching regressions early on.
claremacrae commented

A CMake would be ideal for a fair number of users.

  • 👍2
rnsanchez commented

Agreed; possibly easier to maintain across multiple platforms.

joboccara commented

Indeed! I've tried to add CMake support with this fix. Does it look OK to you?

claremacrae commented

Thanks Jonathan.

I’m not by a computer to be able to test this, but it looks good.

From memory, as a later step, it might be worth calling enable_testing enabling CTest integration.

rnsanchez commented

It worked great; thanks!

(OK by me for closing this issue.)