jodavimehran/code-tracker

Incorrect mapping - checkstyle if block (4cbd709)

flozender opened this issue · 3 comments

checkstyle/checkstyle@4cbd709#diff-b48cc2ff38026f94180847550cd260a0ebefb4a9cb9635e39f5fa2046311d72bR234

Tracking block if(R234) in project Checkstyle and commit 4cbd709, R234 is mapped to L479 L356, but it should be mapped to L424.

@flozender

From what I see in the diff (screenshot below) R234 is mapped to L424

L479 is the closing curly bracket of a catch block. There is no way it can be matched with that.

Screenshot from 2023-08-29 07-49-37

@tsantalis
Sorry, that is a mistake. It maps with L356. The left block goes on to being mapped with a block on the line L479 in another commit and I mixed up the numbers.

This screenshot was taken after the latest commits to RMiner were pulled.

image

After my fix the history starting from checkstyle/checkstyle@4cbd709 is as follows

Commit ID: b84b3fd04ad9c45e1466e35b707a2b59f5baf66b
Date: 2002-09-24T06:34:11
Before: src/checkstyle/com.puppycrawl.tools.checkstyle.Checker#processNEW(String)$if(479-484)
After: src/checkstyle/com.puppycrawl.tools.checkstyle.Checker#processNEW(String)$if(479-484)
introduced: added with method