jods4/aurelia-webpack-build

Don't use FS

jods4 opened this issue · 2 comments

jods4 commented

From @niieani

a potential problem: you are requiring the Node fs module, which is incorrect for any Webpack plugins or loaders. The reason is filesystems can be replaced/mocked by Webpack in certain conditions and make it dynamic or in-memory, and Webpack provides an interface to use the internal fs module, available to the loaders and plugins

jods4 commented

Fixed, now both ExtensionsDependenciesPlugin and GlobDependenciesPlugin probe the compilation.inputFileSystem instead of fs directly.

Nice one. 👍