CI issues
knocte opened this issue · 5 comments
I've seen a couple of issues lately with CI:
- Some lanes fail randomly, e.g.: the one for this recent commit: 4812785
- In our fork where we test several things, we have noticed that the push to nuget.org can happen even if the other CI lanes didn't pass, which is wrong.
Let me investigate
The CI failure itself is caused only in "windows && non-bouncycastle" build in Macaroons.
I remember I had similar issue once before.
I can just stop supporting Macaroons in case of non-bouncycastle build (Or maybe I should stop supporting NSec all together).
But before that I want to support .NET 5 and future versions, so please give me some time to research what is the best way to do so.
I'm pretty sure that this issue does not affect you as long as you are using bouncycastle build. So you can ignore it for now. @knocte
this issue does not affect you
Yeah it doesn't matter for us technically, but it's noise when CI fails for reasons outside our control and the workaround is to just re-run CI.
But before that I want to support .NET 5 and future versions, so please give me some time to research what is the best way to do so.
Sure, but DNL is a library, it doesn't have any executables. Therefore it can stay in .NETStandard form and .NET5 programs can use it just fine.
In our fork where we test several things, we have noticed that the push to nuget.org can happen even if the other CI lanes didn't pass, which is wrong.
And how about this?
I can just stop supporting Macaroons in case of non-bouncycastle build
How about just run Macaroon tests in BC build? and don't include it in the nuget package for the nonBC build
Hotfix merged in #155
In the future probably I must consider either
- Stop supporting NSec build or
- Fixed the test-failure issue on the windows.