joergbrech/moxunit-action

setting up several ext directories

Closed this issue · 2 comments

Hey

Related to bids-standard/bids-matlab#108

Trying to list several ext directories to add to the path of the MOxUnit github action give some weird results.

    - name: MOxUnit Action
      uses: joergbrech/moxunit-action@master
      with:
        tests: tests
        src: +bids 
        ext: JSONio tests/utils      # < ------ External resources to add to the search put (excluded from coverage)
        with_coverage: true
        cover_xml_file: coverage.xml

This fails:
https://github.com/bids-standard/bids-matlab/pull/108/checks?check_run_id=1694214979

The setup phase of the action gives this (amongst other things):

addpath(genpath("/github/workspace/JSONio tests/utils"));

Expected behavior

I think I would have assumed that the set up phase would do something like this.

addpath(genpath("/github/workspace/JSONio"));
addpath(genpath("/github/workspace/tests/utils"));

Am I correct in my expectations?

Thanks for opening an issue! And yes, you are correct, that is a bug coming from here:

if [ -z $EXT ] ; then
EXT=""
else
SETUP="$SETUP addpath(genpath(\"$PWD/$EXT\"));"
fi

In line 54, we would have to split the EXT variable at the whitespace to obtain several local directories and call

SETUP="$SETUP addpath(genpath(\"$PWD/$LOCAL_DIR\"));"

for each one. I am happy to review a PR if you are up for it? 😁

I am happy to review a PR if you are up for it? grin

Will give it a go. :-)