Bump octave version
Opened this issue · 4 comments
Would it be possible to bump the octave version and maybe not depend on qmrilab image for the base build?
Maybe from spm12 docker image? Because the Docker recipe is available
https://github.com/spm/spm-docker
docker pull ghcr.io/spm/spm-docker:docker-octaveThis is related to #12, so tagging you here as well, @agahkarakuzu.
Personally, I wouldn't mind bumping the octave version, the currently used one is quite old. Now I am unsure about the exact docker image we should be using:
- The currently used image comes with some toolboxes and users might rely on this.
- Also, it would feel a bit weird to me to rely on an SPM12 image for a generic octave unit testing action (I do realize that that is the status quo with qmrlab as well...).
Here are some alternative images to use: https://hub.docker.com/search?q=octave&sort=updated_at&order=desc&type=image. For instance, we could use the official GNU Octave docker image and install toolboxes in the Dockerfile in this repo.
That being said, after coming to an agreement on the image to use, I am very happy to accept code contributions :) Changing the docker image itself really just boils down to changing one line
Line 2 in 6cd8737
Hi, I propose advancing on this. I am having some time consuming tests and I think that updating the image used in moxunit could help. I understand that using an image with packages could be preferable, but by now I am proposing the official one as an initial guess.
It seems that the latest qmrlab version is 5.3.0 and the CI tests work. On the other hand, the official image has the 7.3.0 version but some error occurred . What do you prefer? maybe staying with qmrlab is the more appropriate by now.
maybe staying with qmrlab is the more appropriate by now.
Yes, let's take it one step at a time