[FR] Add an option to keep icons offline
Closed this issue · 8 comments
Would it be possible to keep favicons cached so they don't need to load every time? I hope this makes sense.
Thank you for your plugin, it's very useful.
Or saving them to the vault, as I would also like to use them in for example a database view.
Or to same them to the vault, as I would also like to use them in for example a database view.
That's an awesome Ideia indeed. 👏🏻👏🏻
@AaronKnowls I recommend renaming this issue to "Add an option to keep icons offline and not have to re-download them on every page load" or something like that. What do u think?
This FR does not make much sense to me.
Favicons are already cached for one month,
@joethei Obsidian's philosophy and one of their selling points is being offline first, all your notes and entire vault is offline. What if you were offline and that one month passed, then would the favicons be gone? Adding an option to keep them offline would add peace of mind for users, if they go offline then they don't have to worry about already downloaded favicons from going away.
@AaronKnowls Can u reopen the issue?
Storing favicons indefinitely would be a different feature request.
This FR is about caching icons that they don't need to be downloaded every time, which is already implemented.
Keep in mind that storing many small images can lead to serious issues with sync solutions. (Obsidian Sync can take ages to sync icons created by another plugin, other sync solutions might behave similar).
@AaronKnowls Would need to clarify, but I think they meant keeping them stored when he said cached.
I think you should make it an opt-in feature. There are many users including myself that don't use Obsidian Sync.
@YousufSSyed is right, I meant stored.
The scenario to avoid would be to have the icons loading every time I reopen a note, or not having them at all if offline.
Thank you very much to both of you for your interest.