joewalnes/filtrex

Name collision with "require"

JonathanWheeler opened this issue · 1 comments

JonathanWheeler commented

filtrex has a global name collision with requirejs's require. Can we please rename all references to require?

joewalnes commented

This is actually an issue in the jison.js dependency.

A few options:

  1. As part of the build file we find and replace all "require" refs to something else, e.g. "_internal_filterex_require".
  2. We wrap everything in an anonymous function (function() { ... })() so it doesn't pollute the global namespace.

@JonathanWheeler: I'm busy with other projects right now. Want to take a crack at either of these?