joeycastillo/Sensor-Watch

LED always on

Closed this issue · 10 comments

roguepullrequest commented

LITE pcb the LED just stays full YELLOW. Pressing the Light button does turn off the GREEN for the set duration.

Am i missing some default value or something.

joeycastillo commented

This is a build flag issue. You will need to run the make command with the COLOR=RED flag, like so:

make COLOR=RED

Leaving open because this seems to be a becoming a common issue, and I’m wondering if we need to change the build script to error out if board color is not specified.

  • ❤️2
roguepullrequest commented

I did use the color RED. Sadly the Green led has burnt out because it was on too long.

Thankfully i got a couple.

Thanks for making something fun awesome and hackable.

aronhegedus commented

I hit this today, and make COLOR=RED worked for me. I have a red board.

jdek commented

Leaving open because this seems to be a becoming a common issue, and I’m wondering if we need to change the build script to error out if board color is not specified.

To me, COLOR doesn't seem like the right term for something like this, maybe VARIANT would be clearer? (and then requiring it only for the current BOARD)

roguepullrequest commented

So i have use clean repo and still the same issue. I always make sure color is RED.
i even tried other machines to rebuild and still same issue.

The LED both green/red stay on.

joeycastillo commented

To be clear, you're running make COLOR=RED (with both COLOR and RED in all capital letters)?

roguepullrequest commented

To be clear, you're running make COLOR=RED (with both COLOR and RED in all capital letters)?

Yup. Had to triple check my shell history to be sure but using make COLOR=RED to build.

Thanks for everything.

h6y3 commented

To be clear, you're running make COLOR=RED (with both COLOR and RED in all capital letters)?

Yup. Had to triple check my shell history to be sure but using make COLOR=RED to build.

Thanks for everything.

I ran into this issue as well. I did a make clean before I issued the make command and that did the trick for me.

  • 👍1
theorangerider commented

Seems like this issue can be closed? I ran into the same issue and make clean fixed it for me too, thanks!

WesleyAC commented

Going to close this as it seems to be the COLOR issue? @roguepullrequest if you're still having problems, definitely open a new issue.