joeyespo/grip

`safe_join` in Flask is deprecated

bryce-carson opened this issue · 3 comments

bryce-carson commented

safe_join was recently deprecated in Flask, so the current version of Grip is now broken with a recent version of Flask.

freezed commented

Hello all 👋
I confirm this issue, on my Ubuntu:

❯ uname -a && lsb_release -a
Linux laptop 5.4.0-105-generic #119-Ubuntu SMP Mon Mar 7 18:49:24 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 20.04.4 LTS
Release:	20.04
Codename:	focal

I just try @bryce-carson commit ( ea229a5 ) and confirm it fix the issue for me.

Thx 🤝

  • 👍2
fiblan commented

A quick&dirty workaround is install Flask==2.0.3, but @bryce-carson commit (ea229a5) definitely solves it.

joeyespo commented

Grip v4.6.1 with this fix has just been released. Thanks for the PR and quick fix, @bryce-carson!

Upgrade with pip install --upgrade grip.

Feel free to open another issue if there are still issues.

  • 👍6