john681611/ArmaServerManager

Space in modlines stop the server launching mods correctly

Opened this issue · 2 comments

ASM Version: 1.0.0

Brief Description:

Server will fail to launch if a mod that had been added contains a Space in the directory name.

This created .bat file will fail:

del /q C:\GameServers\Arma_3_Server\keys\*.*

xcopy "C:\GameServers\Arma_3_Server\mods\@3den Enhanced\keys" "C:\GameServers\Arma_3_Server\keys" /C /y

xcopy "C:\GameServers\Arma_3_Server\mods\@CBA_A3\keys" "C:\GameServers\Arma_3_Server\keys" /C /y

xcopy "C:\GameServers\Arma_3_Server\Mission Keys\Optional Keys" "C:\GameServers\Arma_3_Server\keys" /C /y

start C:\GameServers\Arma_3_Server\arma3server_x64.exe -mod=C:\GameServers\Arma_3_Server\mods\@3den Enhanced;C:\GameServers\Arma_3_Server\mods\@CBA_A3 -serverMod=C:\GameServers\Arma_3_Server\mods\@LAMBS_Danger.fsm;C:\GameServers\Arma_3_Server\mods\@LAMBS_Suppression -config=C:\Users\Administrator\AppData\Local\Temp\tmpj4nx15.cfg -bepath=C:\GameServers\Arma_3_Server\Server\BattlEye -cfg=C:\GameServers\Arma_3_Server\Server\basic.cfg -port=2302 -profiles=Server -name=Server -filePatching -limitFPS=122

Space in cmd line treat a space as the end of command and need "Some Word" to treat that as one string not "Some" "Word".

Installing mods via the drag and drop html file will pull the name of the mod and use that to create the Symlink, if the mod maker has named a mod like "3den Enhanced", it would name it so, and break.

You can get around it by Modifying the created symlink so that the name changes from "3den Enhanced" to "3denEnhanced", or add the quotation marks to the modline

"-mod=C:\GameServers\Arma_3_Server\mods@3den Enhanced;C:\GameServers\Arma_3_Server\mods@CBA_A3"

Expected:

This Would Work:

del /q C:\GameServers\Arma_3_Server\keys\*.*

xcopy "C:\GameServers\Arma_3_Server\mods\@3den Enhanced\keys" "C:\GameServers\Arma_3_Server\keys" /C /y

xcopy "C:\GameServers\Arma_3_Server\mods\@CBA_A3\keys" "C:\GameServers\Arma_3_Server\keys" /C /y

xcopy "C:\GameServers\Arma_3_Server\Mission Keys\Optional Keys" "C:\GameServers\Arma_3_Server\keys" /C /y

start C:\GameServers\Arma_3_Server\arma3server_x64.exe "-mod=C:\GameServers\Arma_3_Server\mods\@3den Enhanced;C:\GameServers\Arma_3_Server\mods\@CBA_A3" "-serverMod=C:\GameServers\Arma_3_Server\mods\@LAMBS_Danger.fsm;C:\GameServers\Arma_3_Server\mods\@LAMBS_Suppression" "-config=C:\Users\Administrator\AppData\Local\Temp\tmpj4nx15.cfg" "-bepath=C:\GameServers\Arma_3_Server\Server\BattlEye" "-cfg=C:\GameServers\Arma_3_Server\Server\basic.cfg" -port=2302 -profiles=Server -name=Server -filePatching -limitFPS=122

@rhyswilliams999 lastest release should be installed can you confirm it now works?

Can we confirm this is fixed