johnbintz/rack-livereload

Continue execution after an exception.

Closed this issue · 4 comments

theo-bittencourt commented

Hi!

Is possible the rack-livereload continue refreshing the browser after a Rails exception?
I hate need to refresh the browser manually after my code fails.

thanks!

johnbintz commented

It should be. Right now the JS code isn't injected if the response is not 200. If you have a chance, do you want to try and see what the behavior is like when that is changed? The code's in https://github.com/johnbintz/rack-livereload/blob/master/lib/rack/livereload/processing_skip_analyzer.rb#L39. I've thought about this behavior too, but haven't been motivated enough to change it myself, and am too busy for the next few days to experiment with it.

larskanis commented

See #51 for a solution.

theo-bittencourt commented

@larskanis I did a PR for this a year ago: #37 ; )

This issue should be closed, right?

johnbintz commented

It should be. :)