Timeout ignored on Node 12

Question

Timeout ignored on Node 12

johnnysprinkles opened this issue 5 years ago · 8 comments

I'm doing let cert = await sslCertificate.get(host, 10000, port) for a 10 second timeout, but it doesn't seem to be firing ever. If I hit a host that just hangs, this call hangs as well for 2 minutes. Should I put together a minimal repro example?

I did notice that travis.yml only appears to go up to Node 11:

https://github.com/johncrisostomo/get-ssl-certificate/blob/master/.travis.yml

Answer 1 · 2020-01-14T20:38:27.000Z

I'm actually experiencing an issue with v11.13.0 as well not respecting the timeout.

Answer 2 · 2020-02-04T17:15:10.000Z

maybe this would help

Answer 3 · 2020-02-22T10:05:22.000Z

I will create a fork to release this and more. In the meantime you can use patch-package and https://github.com/johncrisostomo/get-ssl-certificate/pull/27.patch

Answer 4 · 2020-02-22T10:34:34.000Z

How can this reproduced locally?

Answer 5 · 2020-06-09T21:31:44.000Z

The changes are available in get-ssl-certificate-next v3.0.0:

https://github.com/DanielRuf/get-ssl-certificate-next

Answer 6 · 2022-03-10T13:48:18.000Z

@DanielRuf the link to the get-ssl-certificate-next repo does not work. Would you please share the correct link? Thank you!

Answer 7 · 2022-03-10T13:53:31.000Z

That was the correct link as of 2 years ago. It has since been taken down. Here's the npm package description: https://www.npmjs.com/package/get-ssl-certificate-next

Answer 8 · 2022-03-10T14:23:05.000Z

I confirmed https://www.npmjs.com/package/get-ssl-certificate-next has the fix implemented and it works. Thank you @DanielRuf !