CPU spikes when left open

Question

CPU spikes when left open

vsim3 opened this issue 6 years ago · 5 comments

vsim3 commented 6 years ago

Hi! Thanks for foliate.

Steps to reproduce the issue:
Open a ebook, scroll some page then left it open for ~1h

Version: 1.2 and git master
OS: Fedora 30

Answer 1 · 2019-06-17T10:41:43.000Z

Confirmed on Ubuntu 19.04, with spike of 25% CPU usage and large 80MB RAM usage for small 400kb file.

Answer 2 · 2019-06-20T07:58:17.000Z

Not sure what's causing this.

Using Web Inspector's Timeline tool, the only thing that's going on seems to be Epub.js polling for resize every 350ms.

If anyone wants to help test this, you can try deleting or commenting out line 4636 in src/assets/epub.js, and see if this still happens.

I just tested it and it seems the CPU spikes are gone.

Answer 3 · 2019-06-20T21:46:45.000Z

Commenting out line 4636 most certainly helped. No known side effects, so far.

Answer 4 · 2019-06-22T09:18:16.000Z

Long testing over hours, with regular page flips confirms commenting out line 4636 in epub.js is a fix.

Answer 5 · 2019-06-23T05:48:11.000Z

Yes, delete line 4636 indeed fix the spikes. One of the things I've noticed is that dictionary lookup sometimes not working, can workaround by maximize foliate (not sure it was there before deleting line 4636).