shell.js clears spinner before controller does on first load

[MartynWynne]

It seems, as it stands, activateController function on shell.js broadcasts the controllerActivateSuccessEvent before any under lying controller has a chance to complete?

To reproduce, put breakpoints on this line in common.js and hit F5

$broadcast(commonConfig.config.controllerActivateSuccessEvent, data);

It is reached twice, firstly by controllerId "shell", then by "dashboard"

Not sure what is the best fix here? I guess a simple one is

if (controllerId !== 'shell') {
$broadcast(commonConfig.config.controllerActivateSuccessEvent, data);
}

But not liking that so much.