Allow color settings to save to Profile, instead of workspace.

Question

Allow color settings to save to Profile, instead of workspace.

Opened this issue 2 years ago · 18 comments

Now that Profiles have left beta, I think it's reasonable to allow peacock settings to be saved based on profile and not just workspace.

I think it would be best to have peacock save the color setting to the active profile that is running.

Given the original purpose of peacock is project based colors I can see why you might want to leave it alone. But I think profiles mirror the workspace spirit in that it can be different for any number of projects.

For us, when we share workspace files to make sure the entire team is using the same settings for certain connections/extensions, not everyone wants a color change.

Answer 1 · 2023-03-10T16:13:13.000Z

Thank you @AferraroMezrah for creating this issue!

Answer 2 · 2023-03-15T12:54:45.000Z

I would second this issue, I continually have to set and remove peacock settings in the projects I work on where workspaces or settings files are tracked.

Answer 3 · 2023-04-06T15:21:49.000Z

Glad to see this has been requested! I'd hate to force my questionable color choices on others :)

Answer 4 · 2023-05-22T08:07:21.000Z

Would that be covered by #7 ?

Answer 5 · 2023-06-21T07:11:36.000Z

I would love to see a progress on that. Settings saved to workspace is a deal-breaker for me.

Answer 6 · 2024-02-01T19:00:59.000Z

I think @thoroc is right this is a duplicate of #7

Answer 7 · 2024-02-02T08:16:03.000Z

Thanks for the ping. I completely forgot all about that one. :)

Answer 8 · 2024-02-02T13:55:14.000Z

@thoroc #7 was written before profiles though. I think it makes sense to include that information on #7, although activity has been slow on that request. Or keep the dedicated profiles request here. Either way!

Answer 9 · 2024-02-07T14:27:42.000Z

@AferraroMezrah
Please read my summary of #7 here
#7 (comment)

You can see that the 'location where the colour information is saved' is dependant upon VSCode itself and unless someone can figure out an amazing hack there is not much https://github.com/johnpapa/vscode-peacock/ can do about it, unfortunately

Answer 10 · 2024-04-23T11:01:05.000Z

I think this is a crucial feature for people who work for organizations.
Maybe a hack that adds a hook for when the project is opened, and also some hooks before and after committing...

Answer 11 · 2024-04-26T12:35:02.000Z

@ncamaa I'm not sure I understand what you're suggesting. It's possible you don't understand the limitation described by #7 (comment)

If you want to see this issue resolved please pester the VSCode team about this issue
microsoft/vscode#40233

Answer 12 · 2024-05-27T12:13:26.000Z

I rarely close my workspace. Could we just have an option to not save anything at all? It's easier to re-apply theme from favourites when opening workspace.

Answer 13 · 2024-05-29T16:42:47.000Z

@AlexSapoznikov I think it's possible you don't understand the limitation described by #7 (comment)

tl;dr: there is no way to tell VSCode to change the colours WITHOUT SAVING TO THE SETTINGS FILE

If you want to see this issue resolved please pester the VSCode team about this issue
microsoft/vscode#40233

Answer 14 · 2024-06-03T12:32:09.000Z

@jadnhm So you are saying that you can not apply new colors without touching .vscode/settings.json?
I thought that the limitation affects only restoring colors when opening vscode.

What I specifically was wondering that would it be possible to apply colors without touching .vscode/settings.json so that when I re-open my vscode it would not restore anything at all? Because right now when I apply a theme and reset settings in git, the theme stays as long as I close and re-open the window. I would just prefer using this without resetting git all the time.

Answer 15 · 2024-06-07T16:12:32.000Z

@AlexSapoznikov

So you are saying that you can not apply new colors without touching .vscode/settings.json?

yes that's exactly what I'm saying. Please read the linked comment from #7 and peruse that issue's other comments for more specifics

#7 (comment) :

What Peacock is attempting is not 'changing the theme' although that's something that could be attempted (probably by another extension?). Peacocks job is to leave EVERY OTHER SETTING besides window 'chrome' colours alone, and themes consist of many settings besides colour (such as fonts, for example)

I would just prefer using this without resetting git all the time

we all would prefer that which is why we're all so angry that microsoft/vscode#40233 has been ignored for so long and why I directed you there in my previous comment.

Answer 16 · 2024-06-11T13:08:02.000Z

@jadnhm I did read the whole thread before writing here. I just managed to misunderstand that vscode settings is also needed for applying colors and not only for restoring. In that case we can close this thread.
Thanks for clarifying!

Answer 17 · 2024-07-05T21:26:11.000Z

@AferraroMezrah Please read my summary of #7 here #7 (comment)

You can see that the 'location where the colour information is saved' is dependant upon VSCode itself and unless someone can figure out an amazing hack there is not much https://github.com/johnpapa/vscode-peacock/ can do about it, unfortunately

I understand the limitation of the requirement to write to the settings.json file now. But the original question was about if the "Profile" feature of vscode can be used here. Does the profile create it's own settings.json? How does VSCode treat profiles.

Right now on my team we share a workspace configuration, but I've noticed that I can use different profiles without affecting our source control. And that's what led to the question, to both better understand profiles and what they do under the hood, and also see if that allows them to be used to control peacock settings in a way that isn't the workspace. Because clearly profiles are storing settings configurations per profile somehow. I was hoping it would apply here?

Answer 18 · 2024-07-29T20:17:42.000Z

@AferraroMezrah why don't you try out what you have in mind and report back?

The goal is to apply colours the way peacock does but you can't touch the file at .vscode/settings.json because that file is checked into source control.